gevent-socketio icon indicating copy to clipboard operation
gevent-socketio copied to clipboard

broadcast_event versus emit naming

Open philipn opened this issue 13 years ago • 2 comments

I'm wondering about the naming of broadcast_event in BroadcastMixin. Would it make more sense to rename this to emit_broadcast instead?

Also, I'm wondering if it'd be possible to have a similar callback / ack for broadcast_event, or if there was a reason to not do that. If it allowed a callback then the API would be more in line, but perhaps there's a good reason it doesn't.

philipn avatar Aug 01 '12 01:08 philipn

@philipn What exactly were you thinking here? I'm not quite clear on what you would want

sontek avatar Apr 13 '13 23:04 sontek

It's been a while since I looked at this code but I'll check back in soon once I have a chance to get my feet wet.

philipn avatar Apr 14 '13 21:04 philipn