sandesh

sandesh copied to clipboard

Hey Abhishek,

Added a class to notify the training on WhatsApp with a free account in Twillio. Let me know if you require additional details.

Regrads, Bishwarup

@bishwarup307 i was thinking of implementing sandesh.whatsapp and sandesh.slack instead. .send wiill have the same behavior as slack so as to not break backwards compatibility. but i can do all this after merging this PR too.

I have some small comments only related to coding standards.

BTW, have you tested if it works?

I have tested it outside of the module and it works as you can see on the screenshots that I had sent you on LinkedIn.

However, there is a syntax error that I have notices after the PR was sent. Will rectify. As per the white spaces, not sure but there are tabs to align the equality signs. Can remove if you prefer without the tabs.

submodule for whatsapp and slack sounds good. I will modify the PR accordingly. Let me know if there’s anything else.

Best, Bishwa

On Tue, 7 Jan 2020 at 6:00 PM abhishek thakur [email protected] wrote:

@bishwarup307 https://github.com/bishwarup307 i was thinking of implementing sandesh.whatsapp and sandesh.slack instead. .send wiill have the same behavior as slack so as to not break backwards compatibility. but i can do all this after merging this PR too.

I have some small comments only related to coding standards.

BTW, have you tested if it works?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/abhishekkrthakur/sandesh/pull/2?email_source=notifications&email_token=ADTFHZY4CIOGSBQY7REVTGDQ4RYW7A5CNFSM4KCGZ3SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIIW2FQ#issuecomment-571567382, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTFHZY4542LCOT7NRGFDMTQ4RYW7ANCNFSM4KCGZ3SA .

-- Sent from my iPhone