weekly-digest icon indicating copy to clipboard operation
weekly-digest copied to clipboard

Ignore issue if it is a Pull request

Open Glennmen opened this issue 6 years ago • 6 comments

According to the Github API docs the Issues endpoint also returns Pull requests: https://developer.github.com/v3/issues/?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc#list-issues

This PR adds an extra filter that removes PR's from the list of Issues. More info can be found in the issue I made #72

Fixes #72

Glennmen avatar Mar 02 '19 17:03 Glennmen

Codecov Report

Merging #73 into master will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   86.70%   86.73%   +0.03%     
==========================================
  Files          24       24              
  Lines         391      392       +1     
  Branches       80       80              
==========================================
+ Hits          339      340       +1     
  Misses         47       47              
  Partials        5        5              
Impacted Files Coverage Δ
src/markdown/markdownIssues.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 410c60e...cb3af17. Read the comment docs.

codecov[bot] avatar Mar 02 '19 17:03 codecov[bot]

Not sure if a test for this is needed. Let me know if I should add a test and how best add it (new test or adjust existing test).

Glennmen avatar Mar 02 '19 19:03 Glennmen

@abhijeetps Can this PR get reviewed please?

Glennmen avatar May 01 '19 19:05 Glennmen

@Glennmen , thank you. The PR looks good. I will test it in Weekly Digest Beta by the end of this month and I will let you know. I have been a little busy lately so, I couldn't come up to check the PR. 😄 I'm really sorry for the delay.

abhijeetps avatar May 09 '19 01:05 abhijeetps

@abhijeetps No problem! Glad to see that there is stil some activity in this useful project. Let me know if you want me to change anything.

Glennmen avatar May 09 '19 07:05 Glennmen

@abhijeetps Have you been able to test this PR yet?

Glennmen avatar Jun 17 '19 20:06 Glennmen