abap2xlsx
Community Call, September 5th 2022
Time: Sep.5th, 18.30 CEST
Duration: 1 hour scheduled, no recording, in English
Invitations: Open for all, message me your email address, and I'll add you to the MS Teams meeting
Agenda:
- Welcome
- own class for cell - ZCL_EXCEL_CELL
- policy for closing stale issues
- please add suggestions in the comments below, and I'll update this list
EDIT: original first post follows: A bit like that in abapGit, would anyone find it a good idea to discuss open issues and perhaps coordinate action on different areas?
@bigld When do we want to schedule it? I'm on holiday for the next two weeks, then three more weeks at work (22.8-9.9) with little chance of breaks during the day (but after 18.00 it's ok), then it's gonna be difficult to plan beyond that. Also, any suggestions regarding the platform to use?
@sandraros other interesting topics? Perhaps we could talk about the 8.0 branch handling which you mentioned in #1050
Here's another idea from me:
- policy regarding "question-like bugs" with no feedback, when would it be ok to close them, whether to ping the author for permission and so on.
@AndreaBorgia-Abo Not really.
Concerning major release 8.0.0, I guess it should happen only when there's a big modification of abap2xlsx that we want to release, little possible regressions like #1050 could then be embarked.
About policy rules to close the issues, I took the decision in the past to close some old questions or issues which can't be reproduced, asking people to confirm, and closing them after 1 month if no answer. I'm okay to follow the rules that you decide, so don't hesitate to propose ones.
@bigld ok, my suggestion is sep.5th, say 18.30-19.30
@larshp can we use Slack for this? Do we need a paid plan? A channel? No clues, really. What other options do we have?
I've used Teams, with paid company account. In Slack its not possible to share stuff without paid account.
Ok, I've created the meeting using Teams and invited the usual suspects. Everyone else just ping me if they're interested. Thanks for the patience, the next time hopefully it'll be better organized: :)
Meeting minutes:
-
(Andrea) closing stale issues:
- ideally ping the author, especially when the issue is unsolved or comes with a PR, otherwise just close it, since it may always be reopened later
- add appropriate labels / answers to the effect that a desidered feature is not yet planned or that the answer is complete, to avoid hurt feelings and encourage participation
- try to limit the "closing spree" to a few issues at a time to avoid frustration
-
(Domi) the cell does not have its own class yet
- idea makes sense and it is worth exploring
- having a dedicated class might increase memory consumption on extremely large files
- implement the new class, either migrating an existing functionality (with shim in original class) or adding a new one, to get a feel for the amount of work required and the possible gotchas
- together with this change, provide a warning (changelog without apack?) or, when possible, cookbook example of the changes to be done when upgrading
- deprecate shims via notes in changelog, when refactor is merged, to be removed in the future
-
(Domi / Lars) Pretty print for whitespace and other minor changes
- proposal to make a once and for all check , similar to #781
- clean up the list of pending PR to reduce conflicts
- later, add specific linter checks to block commits on failure
-
(Lars) unit testing:
- end goal is to run all tests including file generation automatically via free GH actions
- intermediate goal is to run unit tests, adding them as needed
- if a unit test cannot be written, a demo should be supplied for that feature
More or less, this should be all. Comments are welcome.
together with this change, provide a warning (https://github.com/abapGit/abapGit/pull/5285) or, when possible, cookbook example of the changes to be done when upgrading
https://github.com/abapGit/abapGit/pull/5739 :)
