Insta-Downloader-Extension icon indicating copy to clipboard operation
Insta-Downloader-Extension copied to clipboard

Fix Button Alignment for Stories

Open aashutoshrathi opened this issue 7 years ago • 14 comments
trafficstars

Current Look: bug

aashutoshrathi avatar Jan 21 '18 12:01 aashutoshrathi

this is my proposed layout, is this fine with you?

image

adin234 avatar Oct 05 '18 13:10 adin234

Go ahead @adin234

aashutoshrathi avatar Oct 05 '18 18:10 aashutoshrathi

Hey @aashutoshrathi, if we are confirmed that we can use the design which @adin234 has suggested then I can implement that.

lalitmee avatar Dec 22 '18 14:12 lalitmee

We need to do something like that only, but it's better if we can place it in line with three dots.

aashutoshrathi avatar Dec 22 '18 14:12 aashutoshrathi

Yeah that would also be better idea to put in the line and that would also not take up the extra space. :+1:

lalitmee avatar Dec 22 '18 14:12 lalitmee

@lalitmee i think that PR was already merged before

adin234 avatar Dec 23 '18 16:12 adin234

@adin234 Instagram changed the div map for Stories, so it is not working now.

aashutoshrathi avatar Dec 23 '18 16:12 aashutoshrathi

Hey @aashutoshrathi, I was looking for the buttons in the stories but for me, there is no button on the stories.

lalitmee avatar Dec 24 '18 04:12 lalitmee

@lalitmee I have the same issue. I think it has to do with how the content on the page is loaded. The extension does not know when there is new content loaded and therefore doesn't load the buttons.

If you load some stories directly by reloading the story url, the buttons appear (tried this one https://www.instagram.com/stories/alternate.de/). But it doesn't always work, at marvel's story the buttons just won't appear (https://www.instagram.com/stories/marvel/)

And in the case where the buttons do load, they are also displayed correctly as shown further above

leventdeniz avatar Dec 24 '18 11:12 leventdeniz

@leventdeniz then we have to reload the inject button function each time page changes.

aashutoshrathi avatar Dec 24 '18 11:12 aashutoshrathi

@leventdeniz, yeah I think it has something to do loading of the page. But if you notice on the load of instagram we can see the second post's header when we are on the first post.

@aashutoshrathi, yeah we can use any method of Javascript like onscroll for reloading if there is need of that.

lalitmee avatar Dec 24 '18 14:12 lalitmee

@lalitmee I'm already using onscroll

aashutoshrathi avatar Dec 24 '18 14:12 aashutoshrathi

Oh, then we have to debug it why its taking so much time for post other than the 1st one. I think there is something in the if and else condition which is looping again and again.

lalitmee avatar Dec 24 '18 14:12 lalitmee

I tried onload and also tried to listen for url changes but it didn't work for some reason. Didn't had too much time to test this.

leventdeniz avatar Dec 24 '18 14:12 leventdeniz