C-Sharp-Algorithms
C-Sharp-Algorithms copied to clipboard
aalhour
.NetStandard and nuget
Hi,
Are there any plans to migrate this project to .net standard and/or have a nuget package?
Hi @saad749 ,
There are plans but we're not working on them yet. Do you want to submit a PR for it? I'll be more than happy to review and accept it.
Cheers, Ahmad
I've got a few changes that move these from netcore2.0 to netstandard2.0 and also updates the nuspec file (adding the dependency for targetFramework .NETStandard2.0). Would it be better to split those up or keep them together since it's the shift from core app to standard library that created the dependency?
I went ahead and created https://github.com/aalhour/C-Sharp-Algorithms/pull/133 for review. I hope I'm not being rude by going ahead with this rather than waiting for a reply to my earlier question. The PR makes the move from netcoreapp2.0 to netstandard2.0 and I updated the nuspec with the netstandard dependency. Once this gets into nuget.org C-Sharp-Algorithms would be usable by both netcoreapp2 and up, but also older DotNet Framework applications using 4.6.1 and above according to https://docs.microsoft.com/en-us/dotnet/standard/net-standard
I saw the issue was assigned to me, and the PR has been reviewed. What else needs to be done to move this forward?
This is an awesome library, thanks so much to everyone who has put time and effort into it! This issue is a big deal to me; @PatrykOlejniczak @aalhour would it be possible to move this forward?
@aalhour I am willing to take over maintaining this project. Is that something you would consider?
I really like this idea, i can leave my spot since due to some personal things i didn't have time to take care of this repo, and it's sad that repo losing his potential, but let @aalhour make up his mind
@aalhour @PatrykOlejniczak @NdubuisiJr I forked the project and released two NuGet packages. I'm open to discussion about this. You guys have laid a great foundation. However due to the busyness of everyone's schedules, I plan to maintain this fork indefinitely. Contributors are welcome.
- https://www.nuget.org/profiles/C-Sharp-Algorithms
- https://github.com/C-Sharp-Algorithms/C-Sharp-Algorithms
Hi @nloum Thanks for taking the initiative to do this. I love that you created an organization with the project title. It rocks!
Add me to the organization and the new project, so that I can help maintain it when I get the chance to.
Thanks Again.
Hi,
Cool, good job, really nice work that will keep project alive :)
Thanks!
Can this project be archived if it's officially moving to https://github.com/C-Sharp-Algorithms/C-Sharp-Algorithms?
