vapory icon indicating copy to clipboard operation
vapory copied to clipboard

add numpy to requirements

Open deanmalmgren opened this issue 7 years ago • 3 comments

In trying to run the ./examples/cube.py, I got an error about trying to import numpy:

Traceback (most recent call last):
  File "legos.py", line 4, in <module>
    import vapory
  File "/Users/rdm/.virtualenvs/lego-construction/lib/python3.6/site-packages/vapory/__init__.py", line 4, in <module>
    from .vapory import *
  File "/Users/rdm/.virtualenvs/lego-construction/lib/python3.6/site-packages/vapory/vapory.py", line 4, in <module>
    from .io import render_povstring
  File "/Users/rdm/.virtualenvs/lego-construction/lib/python3.6/site-packages/vapory/io.py", line 11, in <module>
    import numpy
ModuleNotFoundError: No module named 'numpy'

I'm not entirely sure numpy is needed, but if it is, it should be listed in the setup.py.

deanmalmgren avatar May 11 '18 17:05 deanmalmgren

Hi managed to solve by installing numpy through pip pip install numpy

maryito avatar Aug 23 '18 16:08 maryito

Ah looks like the code has an except for an IOError but not for a ModuleNotFoundError. That should be fixed. Probably not a lot of people run into this problem since numpy is a very commonly used module.

NGeorgescu avatar Jul 08 '19 03:07 NGeorgescu

This issue has been fixed. If you import the library without numpy it works but if you need numpy for the particular function only then will it stop you.

NGeorgescu avatar Aug 31 '19 12:08 NGeorgescu