mokuro-reader icon indicating copy to clipboard operation
mokuro-reader copied to clipboard

Hidden text "Volume" gets included in the {cloze-suffix}

Open precondition opened this issue 1 year ago • 2 comments

While mining words that appear at the end of speech bubbles, I noticed that the word "Volume" keeps getting added into the Sentence field of my Anki cards.

I noticed the same problem happened across different volumes of the same series I was reading (namely Shadow House [Upscaled]), so I searched for the word "Volume" in the HTML source of the reader and I found this div: offending div I could confirm that this is what YomiChan was picking up by editing the contents of the tag and seeing my modifications appear on new cards I made.

Example of an affected card

image

precondition avatar Dec 28 '23 16:12 precondition

Yeah I've experienced this before, but it actually seems to be more an issue with Yomichan. I managed to recreate this on another website, essentially yomichan is grabbing the text from the notification toast.

I'm not actually sure where yomichan is grabbing the text from in your case though, their shouldn't be any toast with the text "Volume" in the code base, so it might be grabbing the text from the settings menu? That seems to be the only place that text should be visible in the reader.

ZXY101 avatar Jan 06 '24 16:01 ZXY101

This looks to be related to sveltekit's accesibility feature "Announcing the page change", which is pretty undocumented but I found this issue that describes it. Doesn't seem like there's any way of hiding or removing it.

I wonder if there's some way of indicating to yomichan/tan where the sentence boundaries are more explicitly?

walteranderson avatar Mar 07 '24 22:03 walteranderson

Closing for now, for the time being just adjust your yomitan/yomichan termination characters.

ZXY101 avatar May 25 '24 20:05 ZXY101