YPImagePicker icon indicating copy to clipboard operation
YPImagePicker copied to clipboard

showsCrop in MultipleSelection

Open MoonshineSG opened this issue 4 years ago • 4 comments

Describe the bug when selecting multiple photos, the "cropping" screen is skipped

To Reproduce Steps to reproduce the behavior:

  1. Select Multiple Photos
  2. Click on 'Next'

Expected behavior Should display the cropping screens

Screenshots n/a

Environment (please complete the following information):

  • Device: XS
  • OS: 14.5.1
  • Xcode Version 12.5
  • Swift Version 5

Installation Type SPD

Additional context N/A

MoonshineSG avatar May 18 '21 10:05 MoonshineSG

The same way as tapping on a video that has been selected and added to the gallery pops up the trim , on a photo it should pop up a crop. Maybe crop on a video as well?

Or even better, there's that square that indicates "editable". That could be a button to bring up the crop...

MoonshineSG avatar May 19 '21 07:05 MoonshineSG

or use the selection zoom level to apply the crop...

anyway I wonder if anyone reads these...

MoonshineSG avatar May 19 '21 11:05 MoonshineSG

I read it with my morning coffee.

timothyerwin avatar Jul 01 '21 17:07 timothyerwin

@Moonshine, this looks like a cool improvement and I'd suggest you take a shot in a PR if you have time. Please be aware that the team behind this project also have day jobs and very limited amount of time.

s4cha avatar Aug 17 '21 07:08 s4cha