Yingbo Ma

Results 223 comments of Yingbo Ma

Since `transformation_if_inf` is kind of a `f->g` function. It's either going to be type unstable, or we need to introduce the extra overhead for every function call. We should add...

Not really, because it's a higher order function.

I mean `transformation_if_inf` is kind of like a function barrier, and it's type unstable. The actual integration is type stable.

FastGaussQuadrature.jl just gives quadrature nodes and weights. I am not sure what kind of interface we can add to bridge with FastGaussQuadrature.jl

Yeah, I think this is fine. One can always change it manually.

It's because of https://github.com/SciML/SciMLStyle#tests-and-continuous-integration . It's applied generally.

It should be clear with the tests. It just uses the default options. Also, ModelingToolkit still fails with https://github.com/julia-vscode/CSTParser.jl/pull/288

```julia julia> JuliaFormatter.format_text("var\"##iv#469\" = (@variables(t))[1]") ERROR: KeyError: key 0:0 not found Stacktrace: [1] getindex @ ~/.julia/packages/DataStructures/ixwFs/src/sorted_dict.jl:196 [inlined] [2] cursor_loc @ ~/.julia/packages/JuliaFormatter/0Eaux/src/state.jl:19 [inlined] [3] format_text(cst::CSTParser.EXPR, style::DefaultStyle, s::JuliaFormatter.State) @ JuliaFormatter ~/.julia/packages/JuliaFormatter/0Eaux/src/JuliaFormatter.jl:353 [4]...

Yes, you can bypass it easily by ```julia julia> @time solve(prob, Tsit5()); 5.452284 seconds (7.93 M allocations: 789.155 MiB, 3.49% gc time) julia> DiffEqBase.anyeltypedual(::SimulationModel) = Any julia> @time solve(prob, Tsit5());...