graphql-guidelines icon indicating copy to clipboard operation
graphql-guidelines copied to clipboard

Published 20 hours ago • verified publisher icon Yelp

Update deploy_docs.sh

Open mannyluvstacos opened this issue 3 years ago • 2 comments

This PR updates

  • the remote name to https://github/com/Yelp/graphql-guidelines.git
  • the LOCALBRANCHNAME from master to main

to solve the build error that is currently seen in GitHub Actions source

mannyluvstacos avatar Jan 01 '22 22:01 mannyluvstacos

Hi Mark (@magicmark) and Peter (@PeterDraex)!

When you have a moment, I'd love a review on this PR to hopefully help with the GitHub Actions Build/Deploy failure. Thank you for writing these guidelines!

🤔 I think the only part that may need an update is the update of using main instead of master as I am wondering if the localbranch relative to the build is using master.

I'd be more than happy to update! Please let me know :)

I've read the Shopify Guidelines (which we have applied at my current employer) and when I saw Yelp's Guidelines out I was interested to see how y'all were doing things!

mannyluvstacos avatar Jan 01 '22 22:01 mannyluvstacos

Hi @mannyluvstacos,

line 22 on your screenshot says that branch master is being used locally right now. I think we need to change it to main for your changes to work. (And so the build won't stop working in a future version a git.)

git init --initial-branch=main

Disclaimer: I don't work for Yelp.

PeterDraex avatar Jan 01 '22 23:01 PeterDraex