BunnymodXT
BunnymodXT copied to clipboard
Implement Discord RPC
Closes #279
Thumbnails:
https://drive.google.com/drive/u/0/folders/1vvTY2FCAkei0PbhedUxbuvsq6cxOYl4f
Preview:

Notes:
That's a normal that u can't click buttons at own RPC active, it's a bug on Discord side: https://github.com/discord/discord-rpc/issues/353 (but other users still can uses that buttons well, so that isn't useless)
@YaLTeR Is there some more reviews or it can be prepared for merge?
Update (24.07.2022): Got wrote a chapter list for more HL modifications, but covers isn't done yet for them (going do it tomorrow I guess).
tested on ubuntu 22.04:
- works with native steam and flatpak discord using a socket link described here
- unfortunately does not work with both flatpak steam & discord, i assume because steam needs to run through a shell to inject bxt, e.g. openag rpc works fine if you run steam normally.
Giving this a try now with Flatpak Steam and Discord. Sorry it took so long; I don't have much time left with the 40-hour work week internship.
-
Looks like this could use dropping
Difficulty:altogether, I guess it's clear enough if it just says Easy/Normal/Hard, and it should fit this way.
-
Looks like the
fps_maxdisplay does not update live, until a map change. (difficulty too but I guess it doesn't change until a map change anyway?) -
Probably don't need to show FPS and difficulty when in the menu.
-
I like the Barney the Movie default image lol
I guess it's clear enough if it just says Easy/Normal/Hard
And if it's unknown just don't show that part
Giving this a try now with Flatpak Steam and Discord. Sorry it took so long; I don't have much time left with the 40-hour work week internship.
That's fine. I still need to make about new 50+ RPC map covers for a few HL1 modifications (it's boring as fuck), so u still got a time to review code or test it again for a next 1-3 days for at least I think, I will let you know in Discord DMs when I'll fully done with covers to make it ready for merge.
Looks like the
fps_maxdisplay does not update live, until a map change. (difficulty too but I guess it doesn't change until a map change anyway?)
It's also updates state after loading save as well, I don't see a reason to update it in real-time, cuz it will took extra perfomance I think?
I like the Barney the Movie default image lol
😃
In case if u want to use it for own RPC as well instead of making BXT logo, be free to took it:

I don't see a reason to update it in real-time, cuz it will took extra perfomance I think?
I mean just check if fps_max matches the previous value and if not update presence I guess?
Thanks a lot again!