BunnymodXT icon indicating copy to clipboard operation
BunnymodXT copied to clipboard

Implement Discord RPC

Open SmileyAG opened this issue 3 years ago • 9 comments

Closes #279

Thumbnails:

https://drive.google.com/drive/u/0/folders/1vvTY2FCAkei0PbhedUxbuvsq6cxOYl4f

Preview:

preview

Notes:

That's a normal that u can't click buttons at own RPC active, it's a bug on Discord side: https://github.com/discord/discord-rpc/issues/353 (but other users still can uses that buttons well, so that isn't useless)

SmileyAG avatar Jul 14 '22 04:07 SmileyAG

@YaLTeR Is there some more reviews or it can be prepared for merge?

SmileyAG avatar Jul 19 '22 02:07 SmileyAG

Update (24.07.2022): Got wrote a chapter list for more HL modifications, but covers isn't done yet for them (going do it tomorrow I guess).

SmileyAG avatar Jul 24 '22 08:07 SmileyAG

tested on ubuntu 22.04:

  1. works with native steam and flatpak discord using a socket link described here
  2. unfortunately does not work with both flatpak steam & discord, i assume because steam needs to run through a shell to inject bxt, e.g. openag rpc works fine if you run steam normally.

hobokenn avatar Jul 26 '22 10:07 hobokenn

Giving this a try now with Flatpak Steam and Discord. Sorry it took so long; I don't have much time left with the 40-hour work week internship.

  • Looks like this could use dropping Difficulty: altogether, I guess it's clear enough if it just says Easy/Normal/Hard, and it should fit this way.

    image

  • Looks like the fps_max display does not update live, until a map change. (difficulty too but I guess it doesn't change until a map change anyway?)

  • Probably don't need to show FPS and difficulty when in the menu.

  • I like the Barney the Movie default image lol

YaLTeR avatar Jul 30 '22 04:07 YaLTeR

I guess it's clear enough if it just says Easy/Normal/Hard

And if it's unknown just don't show that part

YaLTeR avatar Jul 30 '22 05:07 YaLTeR

Giving this a try now with Flatpak Steam and Discord. Sorry it took so long; I don't have much time left with the 40-hour work week internship.

That's fine. I still need to make about new 50+ RPC map covers for a few HL1 modifications (it's boring as fuck), so u still got a time to review code or test it again for a next 1-3 days for at least I think, I will let you know in Discord DMs when I'll fully done with covers to make it ready for merge.

SmileyAG avatar Jul 30 '22 08:07 SmileyAG

Looks like the fps_max display does not update live, until a map change. (difficulty too but I guess it doesn't change until a map change anyway?)

It's also updates state after loading save as well, I don't see a reason to update it in real-time, cuz it will took extra perfomance I think?

SmileyAG avatar Jul 30 '22 08:07 SmileyAG

I like the Barney the Movie default image lol

😃

In case if u want to use it for own RPC as well instead of making BXT logo, be free to took it:

default

SmileyAG avatar Jul 30 '22 09:07 SmileyAG

I don't see a reason to update it in real-time, cuz it will took extra perfomance I think?

I mean just check if fps_max matches the previous value and if not update presence I guess?

YaLTeR avatar Jul 30 '22 14:07 YaLTeR

Thanks a lot again!

YaLTeR avatar Aug 08 '22 00:08 YaLTeR