YTMD-StreamDeck icon indicating copy to clipboard operation
YTMD-StreamDeck copied to clipboard

fix: socket.io updated

Open eltharynd opened this issue 3 years ago • 3 comments

Ready for incoming YTMD update.

YTMD has some pull requests to update to current version of socket.io. There has been quite some changes to socket.io and the auth system currently used by YTMD is broken on some browsers.

The reason being custom headers are blocked on WebSockets standards, so socket.io has built in auth functionality to guarantee the token will be passed under all circumstances... I personally pushed the PR to YTMD to update those, and i kept backwards compatibility so this won't break on update, regardless we should still update as soon as it comes out.

⚠️⚠️⚠️ Don't push it NOW because they havn't released the update yet, tho I'm already using my custom build of this plugin with a custom build of YTMD and it works as intended.

eltharynd avatar Feb 11 '22 11:02 eltharynd

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Feb 11 '22 11:02 sonarqubecloud[bot]

for reference https://github.com/ytmdesktop/ytmdesktop/pull/900

eltharynd avatar Feb 11 '22 11:02 eltharynd

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 25 '22 23:04 sonarqubecloud[bot]

Do you know of any update on this?

XeroxDev avatar Mar 30 '23 15:03 XeroxDev

I'll close this in favor of #98

XeroxDev avatar Feb 12 '24 16:02 XeroxDev