octocrab icon indicating copy to clipboard operation
octocrab copied to clipboard

feat: add check run pull requests and list parameters

Open oknozor opened this issue 1 year ago • 4 comments

This PR add a few request parameters for the list check run from check suite request (see: https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#list-check-runs-in-a-check-suite)

It also adds the pull_requests field to CheckRun.

This is useful when handling check suite event that are not yet attached to a pull request.

Let me know if anything needs to be changed.

oknozor avatar Nov 26 '23 16:11 oknozor

This PR add a few request parameters for the list check run from check suite request (see: https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#list-check-runs-in-a-check-suite)

I think you meant to link to https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#get-a-check-run , no?

maflcko avatar Nov 29 '23 12:11 maflcko

Friendly ping @XAMPPRocky :)

maflcko avatar Jan 09 '24 08:01 maflcko

Thank you for your PR! Sorry about the delay I've been busy with work and then taking a holiday. It seems there are now conflicts, once those are resolved, we can get this merged.

XAMPPRocky avatar Jan 09 '24 10:01 XAMPPRocky

Just rebased

oknozor avatar Apr 19 '24 10:04 oknozor

Thank you for your PR, and congrats on your first contribution! 🎉

XAMPPRocky avatar Jul 29 '24 08:07 XAMPPRocky