octocrab icon indicating copy to clipboard operation
octocrab copied to clipboard

x25519-dalek compatability

Open BentEngbers opened this issue 2 years ago • 1 comments

I am using your octocrab library to consume github webhooks. i also need the x25519-dalek that is being used within the matrix-sdk. This crate depends on the zeroize version locked to 1.3: https://github.com/dalek-cryptography/x25519-dalek/blob/ea047a218fd77a46af9cf48e9376954b646a2536/Cargo.toml#L42

One of the dependencies of octocrab is secrecy version 0.8.0, which has a minimum requirement of zeroize 1.4. This creates a dependency version conflict. Downgrading the secrecy dependency to version 0.7.0 fixes this conflict with minimal changes. https://github.com/XAMPPRocky/octocrab/commit/719fccbb95130f757060812f27c216be75b14cb3 Ive created a branch that can be easily used:

octocrab = { git = 'https://github.com/BentEngbers/octocrab.git', branch="x25519-dalek-compat" }

I am not sure if this is possible, but perhaps we could make some sort of special release for other people who would like to use these crates together? Or is there a better solution?

BentEngbers avatar Apr 07 '23 09:04 BentEngbers

Thank you for your issue! I'm not sure there's much we can do on the Octocrab side. The issue here is the dalek cryptography suite of crates is largely abandoned and unmaintained.

XAMPPRocky avatar Apr 07 '23 11:04 XAMPPRocky