dependency_validator icon indicating copy to clipboard operation
dependency_validator copied to clipboard

af_2018_abide_for_all

Open dustinlessard-wf opened this issue 7 years ago • 1 comments

Purpose

The following pull request has been auto-generated by App Frameworks to help us roll out the adoption of tooling intended to propagate standards and best practices. This tooling will allow our engineers to more easily keep codebases updated with the latest organization standards.

Changes

The following changes have been made:

  • analysis_options.yaml has been updated with the latest required lints.
  • Abide has been added to your CI build script.

Questions

Please do not merge this pr as we need to add some additional changes that could not be automated.

If you have any questions, please reach out to us in the “Support: H5 / Dart” Hipchat room.

Abide rollout checklist

  • [ ] analysis_options are updated
  • [ ] analysis passes - which likely require fixing lints, warnings and errors
  • [ ] pubspec.yaml has the following installed under dev_dependencies and add if not present: - abide - dependency_validator - semver_audit
  • [ ] Docker/Smithy/Task-Runner has the following and add if not present: - pub run abide - pub run dependency_validator (this will likely need to be configured to exclude some things, for example: pub run dependency_validator -x example/tracing/messaging_middleware,example/tracing/messaging_http_middleware -i coverage,dart_style,dartdoc,semver_audit) - pub run semver_audit (which will need to look like this: pub run semver_audit report --repo Workiva/app_intelligence_dart but configured properly)
  • [ ] check that the repo abides
  • [ ] check that abide was run in CI

@dustinlessard-wf @sebastianmalysa-wf

dustinlessard-wf avatar Jun 22 '18 17:06 dustinlessard-wf

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

aviary-wf avatar Jun 22 '18 17:06 aviary-wf