openverse-api

openverse-api copied to clipboard

Fixes

Follow up on #820.

Description

The fix on #862 probed to reduce the number of failed remove operations for the Publish developer docs job. Before we were getting errors for files under the api/ folder, and currently the problem persists but only for files under the ingestion_server so I believe adding the same user to those containers should fix it.

Compare jobs before and after #820:

• https://github.com/WordPress/openverse-api/runs/7617116799?check_suite_focus=true
• https://github.com/WordPress/openverse-api/runs/7978840111?check_suite_focus=true

Checklist

• [ ] My pull request has a descriptive title (not a vague title like Update index.md).
• [ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
• [ ] My commit messages follow best practices.
• [ ] My code follows the established code style of the repository.
• [ ] I added or updated tests for the changes I made (if applicable).
• [ ] I added or updated documentation (if applicable).
• [ ] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Aug 24 '22 21:08 krysal

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/897

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Aug 24 '22 21:08 github-actions[bot]

This is looking right to me, shall we mark it as ready for review @krysal ?

Aug 27 '22 00:08 zackkrida

The changes made several tests fail, I haven't looked into it yet, so I drafted it to prevent re-ping reviewers until it is fixed.

Aug 29 '22 15:08 krysal