Andrea Giammarchi

Results 554 comments of Andrea Giammarchi

and it does work in ES5 browsers … what are you trying to say?

@kaleb you are addressing, `setPrototypeOf` in IE < 9 must create an `instanceof` the prototype you are passing, nothing that `Object.assign` could solve. The _sham_ simply use `Object.create(proto)` where this...

`instanceof` was a shortcut to say that inheritance should work as such. If you want callable instances with attached methods you can already do that by your own. Being a...

Hint for documents, where CookieStore class should likely extend [EventTarget](https://dom.spec.whatwg.org/#interface-eventtarget) (yes, there is [a polyfill for that](https://github.com/ungap/event-target#readme) too): ```js const {get, set} = Object.getOwnPropertyDescriptor(Document.prototype, 'cookie'); Object.defineProperty(Document.prototype, 'cookie', { get, set(value)...

P.S. to batch multiple changes/delete at once, the dispatch event could be delayed a part ```js let timer = 0; const changed = []; const deleted = []; const dispatch...

P.S.2 if anyone agrees with this proposal I might file a PR although I don't TS much so I hope hints are already helpful, thanks.

will that ever happen?

The test case is in the ticket: > Currently `new CustomEvent('!').constructor === CustomEvent` returns false in IE11 I'm on vacation 'till 26th so I won't change this PR before that...

I'm not lazy, I'm on vacation without internet and my laptop not always with me.

not sure I'm adding anything to this discussion but for what I can tell with my tests, the petit-dom algo seems to be the fastest but there are too many...