ascjs icon indicating copy to clipboard operation
ascjs copied to clipboard

Published 20 hours ago • verified publisher icon WebReflection

Reproducible export * bug

Open bcomnes opened this issue 4 years ago • 2 comments

Demonstrates https://github.com/WebReflection/ascjs/issues/17 as a test case.

Next is to figure out a solution. Adding estree back to the plugins list fixes it, but as noted in https://github.com/WebReflection/ascjs/commit/c6dd7e1b5c8a14a1aa72ddd710728b099b36b0f2 there might be issues with that.

Any ideas?

bcomnes avatar Dec 01 '20 19:12 bcomnes

Thanks for the PR, but I have two questions:

  • does ucjs break too?
  • why there's no "use strict"; directive in the failing test?

WebReflection avatar Dec 02 '20 11:12 WebReflection

does ucjs break too?

Not sure, just found out/was reminded of that package. I will test it out now.

why there's no "use strict"; directive in the failing test?

I believe it gets added by the test runner here:

https://github.com/WebReflection/ascjs/blob/9020158d58040335b928a3dd17fdc87effbd837e/test.js#L144-L151

bcomnes avatar Dec 02 '20 16:12 bcomnes