wabt icon indicating copy to clipboard operation
wabt copied to clipboard

Fix implicit br return

Open dzfrias opened this issue 1 year ago • 2 comments

An in-progress fix for #2304. For now, I believe it's working for any br depth. However, I'm not really sure how to handle the br_if case. Should it be replaced with an if and then a return? If so, I couldn't really find a way to create a new IfExpr and compile that on the fly. Maybe someone with more experience with the decompiler source code has a good way to do it.

dzfrias avatar Nov 10 '23 04:11 dzfrias

I think this PR probably makes you the leading active wasm-decompiler person we have. :-) Your strategy sounds good but I don't think I have any better ideas...

keithw avatar Nov 10 '23 20:11 keithw

Hmm ok. I'll work on finding a solution that works, then!

dzfrias avatar Nov 17 '23 19:11 dzfrias