wabt icon indicating copy to clipboard operation
wabt copied to clipboard

WastParser handling of `(module binary)` and `(module quote)`

Open keithw opened this issue 2 years ago • 1 comments
trafficstars

WastParser seems to:

  • allow (module binary "...") in ParseModule (even though this is not valid syntax for the Wasm text format; it's only valid for scripts), and
  • forbid (module quote "...")in ParseScript, even though this is a valid script command. (It does allow (module quote) when inside (assert_malformed), which is the only thing the spec tests actually use.)

Not saying either of these edge cases is critical, but just documenting for the record. I think it would be nice to tighten up the first one since this seems like a possible avenue for mischief.

keithw avatar Jun 07 '23 17:06 keithw

The annotations.wast test is going to make us implement the second one of these; it uses (module quote) outside of (assert_malformed).

keithw avatar Dec 05 '23 08:12 keithw