wabt icon indicating copy to clipboard operation
wabt copied to clipboard

Published 20 hours ago • verified publisher icon WebAssembly

Fix several issues found by fuzzing

Open Mem2019 opened this issue 3 years ago • 0 comments

Fixes https://github.com/WebAssembly/wabt/issues/1922 Fixes https://github.com/WebAssembly/wabt/issues/1924 Fixes https://github.com/WebAssembly/wabt/issues/1929

Mem2019 avatar Jun 01 '22 18:06 Mem2019

@Mem2019 Thank you for fixing these! Do you have cycles to make the changes requested in the review and get this merged? Would be great to have this in...

keithw avatar Aug 15 '22 22:08 keithw

I wonder if that fact that we were missing those validation checks means there are some tests that are missing from the spec tests? i.e. why didn't the spec tests find these?

I looked into this. In this case, the tail-call proposal tests would have caught these binary-reader-interp bugs (causing a segfault or asan failure). But we're not running the tail-call proposal tests because (I guess?) the interpreter doesn't support tail calls yet. :-(

keithw avatar Sep 17 '22 18:09 keithw