wabt icon indicating copy to clipboard operation
wabt copied to clipboard

There should be more tests for --enable- and --disable-

Open SoniEx2 opened this issue 3 years ago • 1 comments

Currently it seems these are the only tests that test --disable-:

  • https://github.com/WebAssembly/wabt/blob/1f3a1d5fae0296fdf503968131905be9e8f40cf4/test/parse/expr/atomic-disabled.txt
  • https://github.com/WebAssembly/wabt/blob/1f3a1d5fae0296fdf503968131905be9e8f40cf4/test/parse/expr/bulk-memory-disabled.txt
  • https://github.com/WebAssembly/wabt/blob/1f3a1d5fae0296fdf503968131905be9e8f40cf4/test/parse/expr/tail-call-disabled.txt
  • https://github.com/WebAssembly/wabt/blob/30c1e983d30b33a8004b39fd60cbd64477a7956c/test/parse/module/reference-types-disabled.txt

It might be a good idea to add more of these, and make sure they apply to all the other tools, like wasm2c, too.

SoniEx2 avatar Feb 22 '22 16:02 SoniEx2

case in point: https://github.com/WebAssembly/wabt/pull/1836#issuecomment-1047951485

SoniEx2 avatar Feb 22 '22 16:02 SoniEx2