wabt

wabt copied to clipboard

There are other TODOs in the source, but most of these should be small.

• [x] Update output from "type" to "func_type" TODO TODO
• [ ] Rename LoadStoreExpr (maybe MemoryAccessExpr?) TODO TODO
• [ ] Use proper location in binary-reader-interp.cc TODO
• [ ] Implement event matching in interpreter TODO
• [ ] Clean up "out of bounds" memory/table access messages TODO
• [ ] Use u16 for SerializedOpcode in interpreter TODO
• [ ] Move TypeChecker into SharedValidator TODO TODO
• [ ] Change assert_unlinkable to a single-line error TODO
• [ ] Print assert_uninstantiable and assert_exhaustion errors when assertion passes TODO TODO
• [ ] Validate command-line arguments for value-stack-size and call-stack-size TODO TODO TODO TODO
• [x] Fix typo "initializing" TODO
• [ ] Remove ParseTextList, switch usage to ParseTextListOpt TODO TODO

Fixed typo "initializing". #1387

Hey @binji , are most of these items still valid? Would like to pick a few to work on.

My guess is that these are outdated, but I think @sbc100 and @keithw will have more information.

There's still plenty of TODOs in the code (including several of the issues listed here) that seem like fine things to work on.

Other bite-sized-ish priorities could include:

• Getting simd-everywhere to correctly handle the five SIMD tests where it seems to give results not quite in line with the Wasm spec (https://github.com/WebAssembly/wabt/pull/2021#issuecomment-1396386135). Once we get these passing, wasm2c can claim full SIMD conformance and check the box on webassembly.org, which would be really cool.

• Fixing some of the oss-fuzz failures (https://bugs.chromium.org/p/oss-fuzz/issues/list?q=wabt).

Hey @keithw thanks for the reply, will be taking a look in the SIMD tests.

FWIW, I just submitted a PR to SIMDe that gets the SIMD tests passing on Intel (https://github.com/simd-everywhere/simde/pull/1010)