digital-credentials icon indicating copy to clipboard operation
digital-credentials copied to clipboard

IdentityRequestProvider should be renamed something like "options" or "details"

Open marcoscaceres opened this issue 1 year ago • 2 comments

Although this is not "web observable" (because it's a dictionary), the IdentityRequestProvider is not exactly about "providers"... it's more about what the provider need to match on.

It might be good to rename the dictionary IdentityRequestOptions or IdentityRequestDetails or something...

marcoscaceres avatar Feb 05 '24 06:02 marcoscaceres

Concur that IdentityRequestOptions or IdentityRequestDetails would better convey the intent of this thing. I must admit I was somewhat confused reading the initial spec by the name of the thing "used to specify a request protocol and structured request" having the word "provider" in it, when Identity credential provider is seemingly the thing that answers such a request, not part of the request itself.

bc-pi avatar Feb 05 '24 13:02 bc-pi

Sent #71 ... going with "details" because some members are mandatory.

marcoscaceres avatar Feb 06 '24 01:02 marcoscaceres

@marcoscaceres @samuelgoto #71 is still open, but the current spec text uses DigitalCredentialRequestOptions. Are we sticking with that or still considering IdentityRequestDetails?

timcappalli avatar Jun 11 '24 20:06 timcappalli

I think DigitalCredentialRequestOptions is correct in that it is the guidance from the credential management spec and consistent with all of the other credential types:

samuelgoto avatar Jun 12 '24 16:06 samuelgoto