vonage-php-sdk-core icon indicating copy to clipboard operation
vonage-php-sdk-core copied to clipboard

SMS sending freezes the execution if throttle occurs

Open codewahoo opened this issue 3 years ago • 1 comments

Line 51 in src/SMS/Client.php calls PHP sleep function, which expects a timeout in seconds, whereas src/SMS/ExceptionErrorHandler.php throws a ThrottleException object with a timeout in milliseconds. Thus, the script freezes for xxx seconds instead of milliseconds.

codewahoo avatar Feb 20 '22 02:02 codewahoo

Looking at src/SMS/ExceptionErrorHandler.php, it does seem like it's setting the timeout in seconds now. So this should be resolved?

https://github.com/Vonage/vonage-php-sdk-core/blob/main/src/SMS/ExceptionErrorHandler.php#L62

manavo avatar Apr 17 '23 18:04 manavo