Vincent Langlet

Results 629 comments of Vincent Langlet

This should be easier now https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/1669 is merged if you wanna try again @Hanmac

> the only thing that makes it a bit tricky would be that now the default values are removed from SonataAdminBundle (or that part is getting deprecated) it wouldn't be...

IMHO, the rule should only apply to , = and . `==` and `!=` should be handle (or maybe is already) differently, because `===` and `!==` should always be preferred.

> The linked article shows that `$test == 0.3` can be valid code but it would be marked with an error by this PR. Not sure `bcadd(0.1, 0.2, 1);` should...

PHPStan is even able to restrict to non-falsy-string https://phpstan.org/r/462542dc-32e6-433c-8ee9-7adc10a8cdb0

> I did not implement a `soft_fails` logic because I want to know as soon as one of my worker is failing (It's a strategic business advantage to me). I...

HI @dima-gr, can you solve the CI failures ?

> In PHPStan there are errors unrelated to my changes I will take a look in the week

HI @dima-gr, do you have time to finish the PR ? :)

> Looks like PR is stuck Do you want to finish it ?