saml2aws

saml2aws copied to clipboard

This PR adds support for automatically invoking the --skip-prompt flag by setting SAML2AWS_SKIP_PROMPT=true.

I've tried this locally and it works as expected so thankfully, it's a change with a very small scope!

I use OneLogin with saml2aws, along with my credentials stored using macOS keychain. It works great as a credential_process for awscli but when running normally ie; saml2aws login -a "blah", it can be a pain to be asked to confirm my credentials each time, since I've already saved them.

Internally we have some shared environment variables (ie; a shell script you can import) so it'll be nice to just set this one for all developers and have it work rather than say; aliasing saml2aws to include the --skip-prompt flag or remembering to specify it each time.

Thanks!

Would love to see this get merged in.

Codecov Report

Merging #753 (e8ec148) into master (381b1f0) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #753   +/-   ##
=======================================
  Coverage   32.33%   32.33%           
=======================================
  Files          52       52           
  Lines        7502     7502           
=======================================
  Hits         2426     2426           
  Misses       4753     4753           
  Partials      323      323           

Flag	Coverage Δ
unittests	32.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more