DNAnalyzer icon indicating copy to clipboard operation
DNAnalyzer copied to clipboard

Refactor Properties.formatNucleotideCount(String,int,String)

Open VerisimilitudeX opened this issue 3 years ago â€ĸ 4 comments

I've selected Properties.formatNucleotideCount(String,int,String) for refactoring, which is a unit of 4 lines of code and 3 parameters. Addressing this will make our codebase more maintainable and improve Better Code Hub's Keep Unit Interfaces Small guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖 Limit the number of parameters per unit to at most 4.
  • Why❓ Keeping the number of parameters low makes units easier to understand, test and reuse.
  • How 🔧 Reduce the number of parameters by grouping related parameters into objects. Alternatively, try extracting parts of units that require fewer parameters.

You can find more info about this guideline in Building Maintainable Software. 📖


â„šī¸ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: :sparkles: :100:

VerisimilitudeX avatar Oct 20 '22 00:10 VerisimilitudeX

Hi @Verisimilitude11,

Can you assign this to me?

Thanks.

zaino97 avatar Oct 20 '22 21:10 zaino97

@zaino97 how far are you on this issue? Feel free to take more time if you need to.

VerisimilitudeX avatar Oct 27 '22 06:10 VerisimilitudeX

@Verisimilitude11 i have resolved it in the PR https://github.com/Verisimilitude11/DNAnalyzer/pull/253

zaino97 avatar Oct 27 '22 09:10 zaino97

Alright, thanks for working on this!

VerisimilitudeX avatar Oct 27 '22 19:10 VerisimilitudeX