DNAnalyzer

DNAnalyzer copied to clipboard

I refactored the code because the Cyclomatic Complexity of this class (Properties.java) was too high (20 according to IntelliJ CodeMetrics plugin). For this reason I created some extra methods to reduce the complexity, improve readability and make the quality of the code better. I think now the code for this class is easier to understand, the class complexity was reduced to 8.

All committers have signed the CLA.

This looks great @ArchontisKostis! However, I see that it fails CodeScene's Cloud Delta Analysis: Could you try to fix them? If not, this looks fine anyway, I'll approve it. Thanks so much for contributing!

Hello! Thanks for your review! I will check on it and try to fix it as soon as I can. If I won't be able to fix it I will comment here to inform you. 😊

Sounds great! If it isn’t possible, don’t worry too much about it, I’ll approve/merge the PR.

Hey! I really can't think of something to fix it right now. :( So if you want accept the PR and we can make an issue for someone else to help!

Sounds good, I'll approve the PR later today after some testing. In the meantime, could you please open an issue for this? Thanks!

Great! Yes I will make an issue. Thanks!

Though I think it would be better to make the issue after the PR is accepted in order to not confuse anyone and avoid conflicts. Else someone might fix things at the code before the refactoring and there might be a conflict. If you agree of course.

I think that it should be fine if you link this PR to the issue. Thanks for asking!

Great! So when the PR gets accepted I will create an issue and link it here. I will also add the screenshot you added above. 😊😊

@ArchontisKostis could you please resolve the conflicts? Thanks! I'll approve your PR tomorrow once that is done. Thanks for contributing, we really appreciate your time and help!

@ArchontisKostis please resolve conflicts and fix the bugs that I mentioned earlier. Thanks!

Hey i am sorry for disappering like that i got caught up with some assignments and work and did not have time to fix them. I will fix everything as soon as I can. Sorry again.

No worries @ArchontisKostis, it's fine. Let me know once you fix them. Thanks!

@ArchontisKostis could you please clear the conflicts?

@ArchontisKostis another reminder to please resolve the merge conflicts.

This looks great @ArchontisKostis! However, I see that it fails CodeScene's Cloud Delta Analysis: Could you try to fix them? If not, this looks fine anyway, I'll approve it. Thanks so much for contributing!

@ArchontisKostis could you please create separate issues for this? Thanks!