universalviewer icon indicating copy to clipboard operation
universalviewer copied to clipboard

left panel does not show thumbnails side by side

Open nicolasfranck opened this issue 6 years ago • 4 comments

UV version:

 universalviewer@3

I'm submitting a:

  • [x] bug report
  • [ ] feature request => please use the user stories repo
  • [ ] support request => Please do not submit support requests here, use stackoverflow

Current behavior:

In UV version 2, all thumbnails were shown per 2 in the left panel:

http://universalviewer.io/uv.html?manifest=https://adore.ugent.be/IIIF/manifests/archive.ugent.be%3A018970A2-B1E8-11DF-A2E0-A70579F64438#?c=0&m=0&s=0&cv=0&xywh=-5331%2C-516%2C22660%2C10311

In version 3, this does not work anymore:

http://universalviewer.io/examples/#?c=&m=&s=&cv=&manifest=https%3A%2F%2Fadore.ugent.be%2FIIIF%2Fmanifests%2Farchive.ugent.be%3A018970A2-B1E8-11DF-A2E0-A70579F64438&xywh=5216%2C1999%2C5999%2C5416

Strangely enough, all goes well when viewingHint is set to paged:

http://universalviewer.io/examples/#?c=&m=&s=&cv=&manifest=http%3A%2F%2Fwellcomelibrary.org%2Fiiif%2Fb18035723%2Fmanifest&xywh=4%2C1016%2C2620%2C1968

I've looked in the source code, but all seems well there: classes like oneCol and left-to-right are used correctly, width and height of the images are set correctly.

Expected behavior:

Thumbnails in the left panel should be shown per 2.

Steps to reproduce:

Related code:

// insert any relevant code here

Other information:

nicolasfranck avatar Aug 01 '19 14:08 nicolasfranck

I think this is the correct behaviour. You now need to have viewingHint: paged to see thumbs side by side. There are use cases where you want the thumbs to appear in a single column.

edsilv avatar Aug 02 '19 05:08 edsilv

I understand, but in that case the panel becomes too wide. If you set the option panelExpandedWidth to a smaller value, then it becomes a problem for manifests where the viewingHint is paged (thumbnails do not fit next to each other).

And what about the fully expanded gallery? There the thumbnails are always arranged from left to right. I think we should always use all available space. It is simply more condense.

I thought the viewingHint only applied to the viewer (main panel) itself?

nicolasfranck avatar Aug 02 '19 06:08 nicolasfranck

viewingHint now deliberately applies to the thumbnail panel as not all manifests are paged. But I take your point about the gap... Maybe we should increase the size of the thumbs to fit the whole width of the panel? The expanded gallery just lists the thumbnails left-to-right without grouping them into pages, so should be ok as is.

edsilv avatar Aug 09 '19 14:08 edsilv

ok

nicolasfranck avatar Aug 12 '19 09:08 nicolasfranck

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

LlGC-szw avatar Aug 25 '23 11:08 LlGC-szw

This appears to be resolved.

demiankatz avatar Nov 02 '23 16:11 demiankatz