Unity-Robotics-Hub icon indicating copy to clipboard operation
Unity-Robotics-Hub copied to clipboard

Support moving the robot

Open peted70 opened this issue 3 years ago • 1 comments

Use local coordinates for the target and target placement game objects instead of the global ones. These remain constant if you parent the table, robot and markers in order to move as a group. (This supports display on a HoloLens 2 for instance).

Proposed change(s)

Describe the changes made in this PR.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Provide any relevant links here.

Types of change(s)

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Code refactor
  • [ ] Documentation update
  • [ ] Other (please describe)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.

Test Configuration:

  • Unity Version: [e.g. Unity 2020.2.0f1]
  • Unity machine OS + version: [e.g. Windows 10]
  • ROS machine OS + version: [e.g. Ubuntu 18.04, ROS Noetic]
  • ROS–Unity communication: [e.g. Docker]

I have tested this using Unity 2020.3.26f1 and also deployed to a HoloLens2 with ROS1 noetic running on an Ubuntu VM

Checklist

  • [ ] Ensured this PR is up-to-date with the dev branch
  • [ ] Created this PR to target the dev branch
  • [ ] Followed the style guidelines as described in the Contribution Guidelines
  • [ ] Added tests that prove my fix is effective or that my feature works
  • [ ] Updated the Changelog and described changes in the Unreleased section
  • [ ] Updated the documentation as appropriate

Other comments

peted70 avatar Mar 16 '22 14:03 peted70

CLA assistant check
All committers have signed the CLA.

unity-cla-assistant avatar Mar 16 '22 14:03 unity-cla-assistant