jest-environment-hardhat icon indicating copy to clipboard operation
jest-environment-hardhat copied to clipboard

`@uniswap/sdk-core` incorrectly defined as `devDependency`

Open ottodevs opened this issue 3 years ago • 0 comments

Thanks for making this plugin, very useful.

I discovered that "@uniswap/sdk-core" is not a devDependency in this project, it is used as core dependency in src/hardhat, making this plugin impossible to use externally, unless installing that dependency.

On the other hand, it seems the whole Uniswap sdk is just used for just a couple of TS types, I wonder if it couldn't be replaced with just ethers BigNumber or something similar? So it would be more usable, as ethers is already a hardhat typical dependency.

ottodevs avatar Jul 27 '22 04:07 ottodevs