react-spreadsheet-import icon indicating copy to clipboard operation
react-spreadsheet-import copied to clipboard

I currently need to add @chakra-ui/react, @chakra-ui/system, and framer-motion to my package.json

Open lcahlander opened this issue 3 years ago • 8 comments

When I run a npm run build it shows that I need to add the following to my package.json in order to build.

  • @chakra-ui/react
  • @chakra-ui/system
  • framer-motion

These should be automatically included in the build without adding them into my package.json.

lcahlander avatar Jul 19 '22 14:07 lcahlander

Heu @lcahlander could you check what npm version you are using by running npm --version?

masiulis avatar Jul 19 '22 14:07 masiulis

8.13.2

lcahlander avatar Jul 19 '22 14:07 lcahlander

Thanks for letting us know, I think I moved the dependencies to peerDependencies for issue #104. I guess my knowledge of how dependencies are resolved is a bit out of date. For now please add the dependencies manually, we will investigate how to fix this correctly.

masiulis avatar Jul 19 '22 15:07 masiulis

I am also getting an error message on npm install from our corporate servers.

8233 warn tarball tarball data for @chakra-ui/icon@https://xxx.xxx.xxx:443/artifactory/api/npm/npm-virtual/@chakra-ui/icon/-/icon-3.0.4.tgz (sha512-9Ry+fa6EKRYUexffvgOJ9dRIkxCSnASgdSnb09EbQTgCTeM+47LUsxR2+r8pbY6ZT5D4m2zRLkTrv7O7icoyOw==) seems to be corrupted. Trying again.

corporate server domain commented out.

lcahlander avatar Jul 25 '22 18:07 lcahlander

Hey, @lcahlander I really have no experience with artifactory. Is it possible to reproduce this bug locally?

masiulis avatar Jul 25 '22 18:07 masiulis

I struggled installing react-spreadsheet-import component in my project which I created with create-react-app. I tried to install @chakra-ui separately before but it didn't succeed. I downgrade "framer-motion" to "4.1.17 as well.

When my project was created with create-react-app it used react-scripts old version "4.0.3" and I changed to 5.0.1 which works well. But in this current project I can’t upgrade it, because other libs depend on the old version and they end up breaking. If I upgrade to 5 I will need to change babel and webpack which was created by create-react-app and I had a hard time doing this. Can anybody help me to use react-spreadsheet-import with these configurations?

node version v18.1.0

npm version 8.16.0

yarn version 1.22.19

"dependencies": {
   “react": "^17.0.2"
   “react-dom": "^17.0.2"
   “react-scripts": "4.0.3",
   "framer-motion": "4.1.17",
   "@types/react": "^17.0.14",
   "@types/react-dom": "^17.0.9",
   "react-spreadsheet-import": "^2.0.8",
}

moises-paschoalick avatar Sep 24 '22 12:09 moises-paschoalick

Personally, I'd say peerDependencies is correct - the developer opting in to this library should install Chakra UI themselves and the README should include the necessary instructions.

The only alternative is to move Chakra back to dependencies.

However, @masiulis I think this depends on how you want to market this package. Is it..

  1. A spreadsheet import package for React; or
  2. A spreadsheet import package for Chakra which just so happens to be a React UI framework

The README's introduction made me assume the latter. If so, it's understandable the name react-spreadsheet-import might be confusing some folk, as opposed to something like chakra-spreadsheet-import

tl;dr

There's no bug here, just a misunderstanding. Developers as of right now will need to install Chakra themselves alongside react-spreadsheet-import

lukerollans avatar Oct 12 '22 07:10 lukerollans

Hi, I don't know if this belongs here. But I'm getting this error. Any fix to this?

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: [email protected] npm ERR! Found: @chakra-ui/[email protected] npm ERR! node_modules/@chakra-ui/react npm ERR! @chakra-ui/react@"^2.3.6" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer @chakra-ui/react@"^1.8.8" from [email protected] npm ERR! node_modules/react-spreadsheet-import npm ERR! react-spreadsheet-import@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

hamaadsenpai avatar Oct 21 '22 14:10 hamaadsenpai

This should no longer be needed in >4.0.0.

masiulis avatar May 24 '23 16:05 masiulis