node-s3-uploader icon indicating copy to clipboard operation
node-s3-uploader copied to clipboard

Fix awsImageExpires handling

Open gzurbach opened this issue 8 years ago • 0 comments

The example in the README uses 31536000 (365 days in seconds) for both the awsImageExpires and the awsImageMaxAge options.

I concluded that passing the same value for both options would upload images with the both max-age and expires a year from now.

However, since Date.now() returns a value in milliseconds instead of seconds, we must multiply the provided value by 1000 to get the expected result. This PR addresses this issue.

gzurbach avatar Jul 02 '17 00:07 gzurbach