ivy icon indicating copy to clipboard operation
ivy copied to clipboard

feat: added fft2

Open jaskiratsingh2000 opened this issue 2 years ago • 3 comments

Closes: #19052 of #15047

jaskiratsingh2000 avatar Sep 15 '23 07:09 jaskiratsingh2000

@DecFox For same same reason the lint is throwing the formatting error for a line. I have corrected it multiple times even then. Can you please check once? @DecFox

jaskiratsingh2000 avatar Sep 15 '23 08:09 jaskiratsingh2000

Hi @jaskiratsingh2000 , thanks for your contribution to Ivy. Your code looks good to me but I am currently unable to run the unit tests due to a "key error: cpu not found" issue. I will wait for awhile until the issue gets fixed and will return to you to confirm the unit tests are passing!

jieunboy0516 avatar Sep 21 '23 02:09 jieunboy0516

Sorry @jaskiratsingh2000, turns out there is some issue in your code

    |     fft_first_axis = fft(x, n=s[0] if s else None, axis=axes[0], norm=norm)
    | TypeError: 'int' object is not subscriptable

that is causing the unit tests to fail. Could you please take a look and fix it? Thx!

jieunboy0516 avatar Sep 21 '23 02:09 jieunboy0516