Jexl icon indicating copy to clipboard operation
Jexl copied to clipboard

fix(Lexer): Interpret minus correctly

Open Dossar opened this issue 3 years ago • 2 comments

Addresses https://github.com/TomFrost/Jexl/issues/97

Incorporates the suggestion provided in this comment, courtesy of OlivierB-OB: https://github.com/TomFrost/Jexl/issues/97#issuecomment-745129713

Basically, if there is a minus sign for a negative value past the first argument, there is a parsing error. Adding comma to the list of minusNegatesAfter should allow proper interpretation of negative values after the first argument.

Dossar avatar Jun 09 '22 20:06 Dossar

@TomFrost The fix in addition to unit tests have been added in this PR. To me it looks good to merge for fixing this issue, but would like your feedback.

Dossar avatar Jun 10 '22 15:06 Dossar

Hello @TomFrost, any idea when this PR will be merged ?

Arihy avatar Aug 26 '22 08:08 Arihy