Tim M

Results 70 comments of Tim M

> I have run this benchmark 3times (first without struct and memory info) and the numbers were always in this way. Thanks, my numbers were all over the place 😅...

~I'd be happy to do this, should be easy to add~ 🤞

nvm might be a bit trickier than I thought, sorry

Yeah, I think the logic is identical to `IQueryable`. I'd naively thought it would be a quick, simple check for expressions and then write some tests. I hadn't registered that...

Unfortunately `[MapValue(string[] targetPropertyPath, object value)]` wouldn't be compatible with a user generated type. Attribute arguments must be constant at compile time, ie primitives (`int`, `char`), `string` or an array. `[MapValue("RequiredProperty",...

Should this also be applied to non `UnsafeAccessor` code? ie: ```C# if (source.Nested?.Value != null) { target.Value = source.Nested.GetValue.Value); } // equivalent code if (source.Nested?.Value is {} sourceNestedValue) { target.Value...

> - [x] Move all intrinsics code to a separate file (Blake2b_X86). > - [x] Put intrinsics code under "#if NETCOREAPP3_0_OR_GREATER", which AFAIK is the correct minimal version. > -...

- [x] Note that intrinsics aren't available for NETSTANDARD2_1_OR_GREATER, so those directives should be removed (just NETCOREAPP3_0_OR_GREATER). - [x] I'd still like methods on the _X86 classes, e.g.: ```c# public...

I've converted the javadocs to xml form. I've used `` where possible and added summaries when the existing javadoc differed from the `IDigest` description. Nitpick: I've noticed that a couple...

I'll hold off for and convert this to a draft. Want to double check I haven't added a regression for .Net 3