tibiadata-api-go

tibiadata-api-go copied to clipboard

New endpoint is added: v3/forum/section/{name} that returns all the data available on sites:

• https://www.tibia.com/forum/?subtopic=worldboards
• https://www.tibia.com/forum/?subtopic=tradeboards
• https://www.tibia.com/forum/?subtopic=communityboards
• https://www.tibia.com/forum/?subtopic=supportboards

Codecov Report

Merging #215 (0e72293) into v3 (4dd6e10) will decrease coverage by 0.79%. The diff coverage is 60.41%.

@@            Coverage Diff             @@
##               v3     #215      +/-   ##
==========================================
- Coverage   84.08%   83.30%   -0.79%     
==========================================
  Files          22       23       +1     
  Lines        2921     3012      +91     
==========================================
+ Hits         2456     2509      +53     
- Misses        405      441      +36     
- Partials       60       62       +2     

Hi @simivar,

Thanks for your PR first of all!

I will release v4 any day, so it would be great if you could open a PR towards the main branch instead of v3, so that we get the new functionality with the new release.

Kind regards, Tobias

Hey @tobiasehlert,

sure, no problem! Can we get it merged to v3 as well as it's not a breaking change? I will make one more adjustment to the URL so it's more in line with what we have for other URLs and naming on Tibia.com but otherwise it's ready to be merged.

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Hey @tobiasehlert,

MR should be ready to be merged to v3. I'll prepare it for main (v4) in upcoming days. If you can and would like to merge it to both that would be amazing!

Thanks for your contribution @simivar, but since V3 is deprecated I'll not include this PR for now. I'll look into #220 since it's practically identical to this, but for V4 instead.