cloud-storage-rs icon indicating copy to clipboard operation
cloud-storage-rs copied to clipboard

Creation of bucket with `Lifecycle` conditions incomplete

Open ralpha opened this issue 4 years ago • 2 comments

Some conditions are not available in Condition. https://cloud.google.com/storage/docs/json_api/v1/buckets#lifecycle https://cloud.google.com/storage/docs/lifecycle#conditions These are missing:

  • customTimeBefore
  • daysSinceCustomTime
  • daysSinceNoncurrentTime
  • noncurrentTimeBefore

Also separate: I think the documentation for ActionType::Delete is incorrect I think it does not delete the bucket but the objects inside of it. https://cloud.google.com/storage/docs/lifecycle#delete Screenshot from 2021-08-09 17-20-22

I can make a PR for this (and other issues) at some point in the future, but just an issue to keep track of it for now.

ralpha avatar Aug 09 '21 15:08 ralpha

Also Condition does not implement Default.

ralpha avatar Aug 09 '21 15:08 ralpha

A PR for this is definitely welcome! Feel free to submit one!

ThouCheese avatar Aug 11 '21 11:08 ThouCheese