Jonathan White

Results 115 comments of Jonathan White

@Norbert515 , There was an API to be notified via callback, however, it required platform integrations and it only worked on Android Q. This was a complex solution, so I...

> And how is the PlatformBrightness integrated with the DynamicTheme? I can't seem to find a connection. What do you mean by that? I didn't make it a part of...

That should be up to the user. I believe it's only job should be to provide the current value, like orientation builders

~~didPlatformChangeBrightness does look like the official way to do this actually~~ Oh, Nevermind. These are all methods. We're trying to provide a widget with the most recent value

I don't see how it's better than my suggestion solution. When the platformBrightness changes, MediaQuery rebuilds its descendants with that, which my widget depends on, so it works. No callbacks...

> Okay so if I understand this correctly, the `PlatformBrightness` widget gets placed somewhere and provides the brightness. Right now, I'm thinking of apps like Gmail that let you choose...

What are you doing to view the changes? You have to go into system settings on the phone and change the theme to dark mode . This is an android...

> I'm running an emulator w/ Android 10 and changing the theme to dark mode. OK, let me retest

Here's my test on a pixel physical device on Q. ![20191224_122425](https://user-images.githubusercontent.com/23037821/71424649-6f001a80-2648-11ea-9603-543f4f3d1114.gif)