Evan Sharp
Evan Sharp
This isn't a large project which contains many directives, but sure, go for it. I'll accept the PR and publish a new major version. I've moved away from angular myself,...
No preference really, just something short
This and #68 are related, it is the `return false` [in the click handler](https://github.com/d-oliveros/ngSmoothScroll/blob/3200a2269f8c86e5466efe106c7055590eb04802/lib/angular-smooth-scroll.js#L265) which stops the event from propagating to other handlers. This is related to jQuery and jQuery's...
Yes, this doesn't add support for 16.9 as much as it drops support for for older versions of react (which are still listed in the package.json). this library stills works...
Also, react still warns about using `UNSAFE_` methods in strict mode. So by that logic, this PR doesn't work either. We can replace the lifecycle with hooks. While we would...
> We are blocked because of React 13 and 14 No, not 13 and 14... but mostly 15 and [early versions of] 16 since they don't have UNSAFE_ to lifecycle...
This should be more than enough of an example without going into styling. It shows a legit list (ul) where a single item (li) is able to be blocked. https://stackblitz.com/edit/react-24vix1...
try `import reduxMiddleware from 'react-block-ui/lib/reduxMiddleware';`
Looks like it has something to do with the focus calls based on this code comment: https://github.com/facebook/react/blob/c80678c7606b1895573c23182bfb9a418e2ad31e/packages/react-reconciler/src/ReactFiberWorkLoop.js#L605-L607 I'm not sure how to address this.
Yes, if the field value is trimmed when determining if it is empty. Validation (other than required) do not apply to "empty" fields. If you need a different validation, you...