coveralls-python icon indicating copy to clipboard operation
coveralls-python copied to clipboard

fix(reporter: report5): FnmatchMatcher now require `name` argument

Open actionless opened this issue 3 years ago • 1 comments

in new version of python-coverage (ex. 6.1.1) name argument is required, so it's not possible to run the coveralls:

$ COVERALLS_REPO_TOKEN=foo coveralls
Submitting coverage to coveralls.io...
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/coveralls/reporter.py", line 122, in report
    from coverage.report import Reporter  # pylint: disable=import-outside-toplevel
ImportError: cannot import name 'Reporter' from 'coverage.report' (/usr/lib/python3.10/site-packages/coverage/report.py)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/sbin/coveralls", line 33, in <module>
    sys.exit(load_entry_point('coveralls==3.3.0', 'console_scripts', 'coveralls')())
  File "/usr/lib/python3.10/site-packages/coveralls/cli.py", line 95, in main
    result = coverallz.wear()
  File "/usr/lib/python3.10/site-packages/coveralls/api.py", line 252, in wear
    json_string = self.create_report()
  File "/usr/lib/python3.10/site-packages/coveralls/api.py", line 330, in create_report
    data = self.create_data()
  File "/usr/lib/python3.10/site-packages/coveralls/api.py", line 384, in create_data
    self._data = {'source_files': self.get_coverage()}
  File "/usr/lib/python3.10/site-packages/coveralls/api.py", line 404, in get_coverage
    return CoverallReporter(workman, workman.config, base_dir,
  File "/usr/lib/python3.10/site-packages/coveralls/reporter.py", line 23, in __init__
    self.report(cov, conf)
  File "/usr/lib/python3.10/site-packages/coveralls/reporter.py", line 125, in report
    return self.report5(cov)
  File "/usr/lib/python3.10/site-packages/coveralls/reporter.py", line 76, in report5
    matcher = FnmatchMatcher(prep_patterns(config.report_omit))
TypeError: FnmatchMatcher.__init__() missing 1 required positional argument: 'name'

actionless avatar Dec 31 '21 03:12 actionless

hm, i see even after fixing this, another test is still failing with Coverage 6.1.1 - i was looking into it for some time, but didnt figured out what's happening - but seems like some behavior change or bug in Coverage lib itself

actionless avatar Dec 31 '21 19:12 actionless

newest version of coverage/coveralls packages' combo works for me: https://github.com/actionless/pikaur/actions/runs/7382396252

so closing this incomplete PR then

actionless avatar Jan 03 '24 18:01 actionless