Java icon indicating copy to clipboard operation
Java copied to clipboard

Temperature conversion added to conversions - issue#5042

Open TharunSM opened this issue 1 year ago • 8 comments

  • [x] I have read CONTRIBUTING.md.
  • [x] This pull request is all my own work -- I have not plagiarized it.
  • [x] All filenames are in PascalCase.
  • [x] All functions and variable names follow Java naming conventions.
  • [x] All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • [x] All new code is formatted with clang-format -i --style=file path/to/your/file.java

TharunSM avatar Feb 14 '24 09:02 TharunSM

added the junit test required

TharunSM avatar Feb 14 '24 17:02 TharunSM

have change the code to sloap and intercept type, please review it

TharunSM avatar Feb 18 '24 07:02 TharunSM

@TharunTech please have a look again at my previous comment: https://github.com/TheAlgorithms/Java/pull/5048#pullrequestreview-1881955440

The piece of code there has just few gaps. Please fill them.

vil02 avatar Feb 19 '24 19:02 vil02

im not sure what do u mean

TharunSM avatar Feb 20 '24 05:02 TharunSM

the code u commented doesnt provide coversion for all the temp types

TharunSM avatar Feb 20 '24 05:02 TharunSM

the code u commented doesnt provide coversion for all the temp types

This is one of the gaps, which needs to be filled.

vil02 avatar Feb 22 '24 22:02 vil02

@TharunTech how is the progress?

vil02 avatar Mar 19 '24 21:03 vil02

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution!

github-actions[bot] avatar Apr 27 '24 00:04 github-actions[bot]

Please reopen this pull request once you have made the required changes. If you need help, feel free to ask in our Discord server or ping one of the maintainers here. Thank you for your contribution!

github-actions[bot] avatar May 04 '24 00:05 github-actions[bot]