domecode-opensource icon indicating copy to clipboard operation
domecode-opensource copied to clipboard

Some tests are skipped due to duplicate names

Open code-review-doctor opened this issue 4 years ago • 1 comments

Test names must be unique per scope otherwise the second test overrides the first one with the same name.

For example if you had a test file that does:

def test_a():
    pass

def test_a():
    pass

Then only the second test_a will be ran. More details here.

These are the tests that are overriding previously defined tests due to this problem:

https://github.com/The-Domecode/domecode-opensource/blob/8341c944503b715143ea1311570a637134230b3c/todo/tests/test_urls.py#L17 https://github.com/The-Domecode/domecode-opensource/blob/8341c944503b715143ea1311570a637134230b3c/todo/tests/test_urls.py#L21 https://github.com/The-Domecode/domecode-opensource/blob/8341c944503b715143ea1311570a637134230b3c/todo/tests/test_urls.py#L25 https://github.com/The-Domecode/domecode-opensource/blob/8341c944503b715143ea1311570a637134230b3c/todo/tests/test_urls.py#L29 https://github.com/The-Domecode/domecode-opensource/blob/8341c944503b715143ea1311570a637134230b3c/todo/tests/test_models.py#L16

I found this issue automatically, see other issues here

code-review-doctor avatar Feb 21 '22 09:02 code-review-doctor

Message that will be displayed on users' first issue

github-actions[bot] avatar Feb 21 '22 09:02 github-actions[bot]