Florian Bruhin

Results 1183 comments of Florian Bruhin

# Version parsing changes ``` FAILED tests/unit/misc/test_elf.py::test_result - assert None is not None FAILED tests/unit/utils/test_version.py::TestWebEngineVersions::test_real_chromium_version - AssertionError: assert '94.0.4606.126' == '98.0.4758.90' ``` with: ``` @pytest.mark.skipif(not utils.is_linux, reason="Needs Linux") def test_result(qapp,...

# New error logging in `test_select_download_path` **Still reproducible with the release candidate** ``` ERROR tests/end2end/features/test_downloads_bdd.py::test_select_download_path - end2end.fixtures.testprocess.InvalidLine: ``` ``` E end2end.fixtures.testprocess.InvalidLine: E [2452475:2452475:0715/110202.601350:ERROR:interface_endpoint_client.cc(658)] Message 4 rejected by interface blink.mojom.WidgetHost E...

# New logging format for SSL errors ``` ERROR tests/end2end/features/test_open_bdd.py::test_open_s[http://] - end2end.fixtures.testprocess.InvalidLine: ERROR tests/end2end/features/test_open_bdd.py::test_open_s[] - end2end.fixtures.testprocess.InvalidLine: ERROR tests/end2end/features/test_prompts_bdd.py::test_ssl_error_with_contenttlscertificate_errors__loadinsecurely - end2end.fixtures.testprocess.InvalidLine: ERROR tests/end2end/features/test_prompts_bdd.py::test_ssl_error_with_contenttlscertificate_errors__block - end2end.fixtures.testprocess.InvalidLine: ERROR tests/end2end/features/test_prompts_bdd.py::test_ssl_error_with_contenttlscertificate_errors__ask__yes - end2end.fixtures.testprocess.InvalidLine: ERROR tests/end2end/features/test_prompts_bdd.py::test_ssl_error_with_contenttlscertificate_errors__ask__no...

# New `GL format 0 is not supported` warnings Logged repeatedy on stdout when running interactively, though with no recognizable breakage: ``` 11:07:09 DEBUG modes tabbedbrowser:_leave_modes_on_load:777 Ignoring leave_on_load request due...

# Dark mode changes ``` FAILED tests/end2end/test_invocations.py::test_preferred_colorscheme_with_dark_mode - AssertionError: Color probing failed, values on last try: FAILED tests/end2end/test_invocations.py::test_dark_mode[blank-lightness-hsl-colors1] - AssertionError: Color probing failed, values on last try: FAILED tests/end2end/test_invocations.py::test_dark_mode[blank-brightness-rgb-colors2] -...

# Missing focus rectangles when selecting text fields with hints With `.venv-qt64/bin/python3 -m qutebrowser --temp-basedir tests/end2end/data/insert_mode_settings/html/textarea.html`, when pressing `f`, `a`, the text field is in focus and retrieves input, but...

Relevant part of the logs: ``` 14:37:29 DEBUG webview browsertab:_set_load_status:1007 load status for : LoadStatus.success [...] 14:37:39 DEBUG webview webenginetab:_js_cb_single:752 Got element from JS: {'attributes': {'href': 'target-blank.html', 'rel': 'noreferrer noopener',...

Why? We already have a `Padding` type we use elsewhere, so it seems to make sense to use it here too, no?

Such a page could also display release notes after upgrades and perhaps other important information.