trogon
trogon copied to clipboard
feat: Add support for Typer
Hey @willmcgugan, You don't have a CONTRIBUTING.md on this repo, so I'm not sure if/how I can contribute to this, but these are the changes I made on my fork to get Trogon working in my Typer app. I have a few TODOs below but would like your input for desired usage and best practice. Thank you 🙏
TODO:
- [ ] match desired usage
- [ ] tests based on best practice
Removed the dependency requirement on typer and created an extra for it. This pattern of init_tui(app) feels more intuitive than shoehorning the decorator to work with a library that suggests creating many nested apps.
I'm weighing the benefits of being able to add this to a single command in typer, as the pattern set out in the docs would be to create a nested app for that.
Hi @darrenburns - I made a PR against @evanmags' branch fixing the docs. When he merges that, your review will be included; is there anything else that needs to be done to make this land?