Tan to the Dashi
Tan to the Dashi
Didn't know that. Will definitely add that as well.
Looks like a duplicate of #213
Just me 5 cents on this: Personally I think both are valid and I don't have a personal preference. However wouldn't a name clash occur when renaming all the `make___`...
If currently no one is working on this, would love to tackle it and get that on the way.
After some discussion in the Discord about this @hhenrichsen made a good point. We probably should implement this functionality properly rather than logging a warning and restricting the user. So...
Please use Git `fixup` commits rather than making a new commit to make review changes as described in the [Contribution Guide](https://github.com/motion-canvas/motion-canvas/blob/main/CONTRIBUTING.md#addressing-review-feedback). Just helps us of having a cleaner commit history
Be sure to squash the `fixup` commits together so they are just one commit (`feat(2d) add Icon Component`). You should be able to achieve with what @hhenrichsen mentioned: `git rebase...
Having the same issue. Tried multiple NodeJS versions as well as Electron ones. Also am running Windows 10 so seams that its a MSBuild issue. Using VisualStudio Build Tools 2019...
Found some insights as to why this is not working with electron: https://stackoverflow.com/a/71437339 Will probably never work unless you downgrade to electron `12.x.x` or `node-gyp` allows to compile with `clang`...
@spydon Yes the problem still exists even with `melos 3.4.0` installed. ```bash > dart run melos run test /bin/sh: melos: command not found ```