router icon indicating copy to clipboard operation
router copied to clipboard

Published 20 hours ago • verified publisher icon TanStack

Devtools visible in production build

Open danielbayerlein opened this issue 3 years ago • 2 comments

Describe the bug

Currently, the devtools are also displayed in the production build. According to the documentation, they should not be displayed.

Version

"@tanstack/react-location": "^3.6.1",
"@tanstack/react-location-devtools": "^3.4.4",

Expected behavior

Devtools are displayed only in the development environment.

Additional context

Initially, the problem was fixed with commit 5f019c812808e084c6b48a6a8f30b61efdc2639c.

danielbayerlein avatar Feb 18 '22 07:02 danielbayerlein

@tannerlinsley is it possible to get this resolved? react-query devtools don't show in production builds but react-location does.

reintroducing avatar Mar 16 '22 20:03 reintroducing

Because of the way the new build system works we can’t build it the same way as React Query. For now, I would suggest creating a dynamic import of the React Location devtools that depends on your build systems environment variable

Tanner Linsley On Mar 16, 2022, 2:15 PM -0600, Matt Przybylski @.***>, wrote:

@tannerlinsley is it possible to get this resolved? react-query devtools don't show in production builds but react-location does. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: @.***>

tannerlinsley avatar Mar 16 '22 20:03 tannerlinsley

Can we get the documentation updated accordingly?

drenther avatar Oct 28 '22 07:10 drenther