taller-test

taller-test copied to clipboard

I had to change the Drupal port to 8081. After the two changes I could login into the App. Is this a valid option to create a PR for?

diff --git a/docker-compose.yml b/docker-compose.yml
index 8c4b0b5..d688f67 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -21,7 +21,7 @@ services:
         GROUP_ID: "$GROUP_ID"
     hostname: app
     ports:
-      - "80:80"
+      - "8081:80"
       - "3000:3000"
     dns:
       - 8.8.8.8
diff --git a/docker/Dockerfile b/docker/Dockerfile
index e8bb74f..fca53b6 100644
--- a/docker/Dockerfile
+++ b/docker/Dockerfile
@@ -72,7 +72,7 @@ RUN sudo cp -R /root/.composer /${USER_NAME}/.composer \
 # Setup default App variables.
 # ----------------------------
 
-ENV GRAPHQL_HOST="http://localhost/graphql"
+ENV GRAPHQL_HOST="http://localhost:8081/graphql"
 
 # Configure entrypoint.
 # ---------------------

Indeed people my face issues with port mapping, but I guess in this case we should either keep the port as is, or make it configurable too, not change it to a less predictable value. Thanks for the help, though!

@sebas5384 could we make this more configurable?

Why close this issue while you opted

we should either keep the port as is, or make it configurable too, not change it to a less predictable value.

I asked

Is this a valid option to create a PR for?

So I guess it is right? Please reopen so we can continue the discussion.

Sorry, I actually pressed the wrong button ¬¬